Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update energy balance for residential based on new Eurostat data #1025

Merged
merged 7 commits into from
May 21, 2024

Conversation

yerbol-akhmetov
Copy link
Contributor

Changes proposed in this Pull Request

Good day. Here, I propose to update the residential part of the energy_totals based on disaggregated Eurostat's household data. The provided function updated total residential, total residential space, total residential water, and total residential cooking based on the data in https://ec.europa.eu/eurostat/databrowser/view/nrg_d_hhq/default/table?lang=en.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A release note doc/release_notes.rst is added.

@fneum
Copy link
Member

fneum commented Apr 14, 2024

Thanks @yerbol-akhmetov! Let us know when this is ready to review.

In the meantime. Would it be possible to do this with the currently used eurostat April 2023 version or alternatively combine it with an update of the whole workflow to eurostat February 2024 version? I'd avoid mixing the versions.

@yerbol-akhmetov
Copy link
Contributor Author

yerbol-akhmetov commented Apr 15, 2024

Thanks @yerbol-akhmetov! Let us know when this is ready to review.

In the meantime. Would it be possible to do this with the currently used eurostat April 2023 version or alternatively combine it with an update of the whole workflow to eurostat February 2024 version? I'd avoid mixing the versions.

Thanks for the comment, @fneum. Maybe I interpret it wrongly, there is no versioning in February 2024 data. It was just lastly updated at that time. However, I also found the Eurostat March 2024 version for energy balances (the same format as in April 2023). But does it make sense to update 2023 data to 2024, since majority of the data are past values which are equal? The only difference is that 2024 data contains 2022's energy balances.

@yerbol-akhmetov
Copy link
Contributor Author

yerbol-akhmetov commented Apr 15, 2024

Thanks @yerbol-akhmetov! Let us know when this is ready to review.

In the meantime. Would it be possible to do this with the currently used eurostat April 2023 version or alternatively combine it with an update of the whole workflow to eurostat February 2024 version? I'd avoid mixing the versions.

It would be great if you can review it.

@yerbol-akhmetov yerbol-akhmetov marked this pull request as ready for review April 18, 2024 15:06
@fneum fneum added this to the v0.11.0 milestone May 12, 2024
@fneum fneum merged commit 4e85ddc into PyPSA:master May 21, 2024
5 checks passed
@fneum
Copy link
Member

fneum commented May 21, 2024

Thanks, @yerbol-akhmetov! It looked mostly good. I took the liberty of extending this to the electricity shares as well to ensure consistency between total and electricity and simplify the code a bit.

see 703b206

@yerbol-akhmetov
Copy link
Contributor Author

Thanks, @yerbol-akhmetov! It looked mostly good. I took the liberty of extending this to the electricity shares as well to ensure consistency between total and electricity and simplify the code a bit.

see 703b206

Super, thanks for handling it.

@yerbol-akhmetov yerbol-akhmetov deleted the update_households_energy branch May 21, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants